WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

[WebGPU] Fix RenderPipeline color format validation

Open achristensen07 opened this issue 2 years ago โ€ข 2 comments

0756f8a30b32823b6da2b7d970481fa7cf37dade

[WebGPU] Fix RenderPipeline color format validation
https://bugs.webkit.org/show_bug.cgi?id=270333
rdar://123810621

Reviewed by NOBODY (OOPS!).

If fragment.targetCount is not equal to descriptor.colorFormatCount then we want to
verify that all color formats are undefined.  Otherwise, we want to verify that they
are all equal to the descriptor color formats.

* LayoutTests/fast/webgpu/render-bundle-validation-color-format-expected.txt: Added.
* LayoutTests/fast/webgpu/render-bundle-validation-color-format.html: Added.
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::validateRenderBundle const):

https://github.com/WebKit/WebKit/commit/0756f8a30b32823b6da2b7d970481fa7cf37dade

Misc iOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โณ ๐Ÿงช wpe-wk2
โœ… ๐Ÿงช webkitperl loading ๐Ÿงช ios-wk2 loading ๐Ÿงช api-mac loading-orange ๐Ÿงช api-wpe
โณ ๐Ÿงช ios-wk2-wpt loading ๐Ÿงช mac-wk1 โœ… ๐Ÿ›  gtk
โณ ๐Ÿ›  ๐Ÿงช jsc loading ๐Ÿงช api-ios loading ๐Ÿงช mac-wk2 โณ ๐Ÿงช gtk-wk2
โœ… ๐Ÿ›  tv loading ๐Ÿงช mac-AS-debug-wk2 โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2-stress
loading ๐Ÿ›  watch
โœ… ๐Ÿ›  watch-sim

achristensen07 avatar Mar 01 '24 06:03 achristensen07

Committed 275550@main (fcdb5d4b016f): https://commits.webkit.org/275550@main

Reviewed commits have been landed. Closing PR #25337 and removing active labels.

webkit-commit-queue avatar Mar 01 '24 14:03 webkit-commit-queue