WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

CredentialRequestOptions gains a "digital" member

Open marcoscaceres opened this issue 1 year ago โ€ข 6 comments

1165b35a55b5b0bfe9a46d787da683dc5196a638

CredentialRequestOptions gains a "digital" member
https://bugs.webkit.org/show_bug.cgi?id=270196
rdar://123744112

Reviewed by NOBODY (OOPS!).

Adds "digital" member to CredentialRequestOptions dictionary:
https://wicg.github.io/digital-identities/#extensions-to-credentialrequestoptions-dictionary

Given the spec changed names again, changed pref name to DigitalIdentityEnabled and updated a few files to reflect the name change.

Adds the ENABLE_DIGITAL_CREDENTIALS compile-time flag to enable the feature.

* LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https-expected.txt: Copied from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https-expected.txt.
* LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https.html: Renamed from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https.html.
* LayoutTests/http/wpt/credential-management/setDigitalCreditialsEnable.https-expected.txt: Renamed from LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https-expected.txt.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h:
* Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.idl:
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl:
* Source/WebCore/Modules/identity/Navigator+Identity.idl:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

https://github.com/WebKit/WebKit/commit/1165b35a55b5b0bfe9a46d787da683dc5196a638

Misc iOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios loading ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โณ ๐Ÿงช wpe-wk2
โœ… ๐Ÿงช webkitperl loading ๐Ÿงช ios-wk2 loading ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โณ ๐Ÿงช ios-wk2-wpt loading ๐Ÿงช mac-wk1 loading ๐Ÿ›  gtk
loading ๐Ÿ›  ๐Ÿงช jsc loading ๐Ÿงช api-ios loading ๐Ÿงช mac-wk2 loading ๐Ÿงช gtk-wk2
โœ… ๐Ÿ›  ๐Ÿงช jsc-arm64 โœ… ๐Ÿ›  tv loading ๐Ÿงช mac-AS-debug-wk2 loading ๐Ÿงช api-gtk
โœ… ๐Ÿ›  tv-sim loading ๐Ÿงช mac-wk2-stress โœ… ๐Ÿ›  jsc-armv7
โœ… ๐Ÿ›  watch โœ… ๐Ÿงช jsc-armv7-tests
โœ… ๐Ÿ›  watch-sim

marcoscaceres avatar Feb 28 '24 07:02 marcoscaceres

Committed 275616@main (3850dd46c4e4): https://commits.webkit.org/275616@main

Reviewed commits have been landed. Closing PR #25216 and removing active labels.

webkit-commit-queue avatar Mar 04 '24 08:03 webkit-commit-queue