WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

[WebIDL] Cache extended attributes of WebIDL file

Open dpino opened this issue 2 years ago • 3 comments

1f8c9e398af4817d65e6acf3a146a8015a4ee85c

[WebIDL] Cache extended attributes of WebIDL file
https://bugs.webkit.org/show_bug.cgi?id=241960

Reviewed by NOBODY (OOPS!).

* Source/WebCore/bindings/scripts/CodeGenerator.pm:

(GetInterfaceExtendedAttributesFromName): Store results into a cache
indexeded by IDL filename, so we don't need to parse the same file
again.
(ComputeIsCallbackInterface): Use slurp function to read file contents.
(ComputeIsCallbackFunction): Use slurp function to read file contents.

dpino avatar Jun 24 '22 09:06 dpino

Is there a mechanism to invalidate the cache when the IDL changes?

weinig avatar Jun 24 '22 20:06 weinig

Is there a mechanism to invalidate the cache when the IDL changes?

I implemented the same mechanism used by GetDictionaryByType or GetEnumByType.

dpino avatar Jun 27 '22 04:06 dpino

Is there a mechanism to invalidate the cache when the IDL changes?

No. But it’s an in-memory cache during the runtime of the script, not an on-disk cache.

darinadler avatar Oct 15 '22 04:10 darinadler

Committed 255617@main (c7da26fb5135): https://commits.webkit.org/255617@main

Reviewed commits have been landed. Closing PR #1769 and removing active labels.

webkit-commit-queue avatar Oct 17 '22 11:10 webkit-commit-queue