Speedometer icon indicating copy to clipboard operation
Speedometer copied to clipboard

Consider using lang attribute for TodoMVC forms that use japanese characters

Open camillobruni opened this issue 6 months ago • 1 comments

This would follow best practise a bit better and make it clearer that we want to render non-english test.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/lang

camillobruni avatar Jun 12 '25 12:06 camillobruni

+1, in addition, this is and related pages might be useful resources.

  • https://www.w3.org/International/questions/qa-html-language-declarations
  • https://www.w3.org/International/tutorials/language-decl/

In particular, I have observed that several of the TodoMVC tests, in particular TodoMVC-JavaScript-ES5 uses Japanese text without language tagging and without specifying a font that supports the Japanese glyphs to be rendered, forcing a font fallback path.

In the context of the intention of this sub-bench, I don't think this is a code path that should be exercised here. For content on the web, I would usually suggest to provide either web- or system-font coverage and add language tagging.

If the intention is to test fallback, that could be made explicit in a different test.

drott avatar Jun 12 '25 12:06 drott