Speedometer icon indicating copy to clipboard operation
Speedometer copied to clipboard

Tweak NewsSite test step scenarios

Open lingyuncai opened this issue 1 year ago • 7 comments

This proof of concept illustrates potential tweaks to the test steps for the NewsSite workload. It introduces an extra navigation to a new tab instead of repeatedly toggling the drop-down menu.

image

lingyuncai avatar Nov 19 '24 07:11 lingyuncai

I'm not opposed to this change in general. @flashdesignory what's your take here? How much slower does the test run now?

camillobruni avatar Dec 03 '24 14:12 camillobruni

btw, you can use crossbench to create browser comparison data easily.

camillobruni avatar Dec 03 '24 17:12 camillobruni

Hi @camillobruni, thanks for your comments.

Below are the crossbench results for this PR from 10 runs. We ran the whole benchmark and extracted the scores for NewsSite cases.

this PR

browser              Google Chrome        Firefox              Safari
NewsSite-Next        75.03 ± 0.92%        64.70 ± 0.90%        86.99 ± 0.61%
NewsSite-Nuxt        47.72 ± 0.98%        53.09 ± 1.2%         59.44 ± 0.92%
Score                36.45 ± 0.63%        31.74 ± 0.67%        31.41 ± 0.45%

main

browser              Google Chrome        Firefox              Safari
NewsSite-Next        64.35 ± 0.79%        63.03 ± 0.80%        71.6 ± 1.9%
NewsSite-Nuxt        62.70 ± 0.85%        70.6 ± 1.8%          76.33 ± 0.14%
Score                36.21 ± 0.53%        31.45 ± 0.90%        31.34 ± 0.59%

System and browser version

browser              Google Chrome        Firefox              Safari
version              131.0.6778.86        133.0                19618.1.15.11.12
os                   macos 14.4 arm64     macos 14.4 arm64     macos 14.4 arm64
device               Mac14,7              Mac14,7              Mac14,7
cpu                  Apple M2 8 cores     Apple M2 8 cores     Apple M2 8 cores
runs                 10                   10                   10
failed runs          0                    0                    0

Basically, NewsSite-Next runs slower while NewsSite-Nuxt runs faster. This difference is related to how each framework handles router.push().

In NewsSite-Nuxt, the Vue router leverages microtasks for its navigation mechanism, so a forced layout of a new tab does not happen synchronously. However, in NewsSite-Next, router.push() is executed synchronously, resulting in a forced layout in sync time when clicking the drop-down menu again.

lingyuncai avatar Dec 05 '24 05:12 lingyuncai

Hi @camillobruni,

Just kindly ping :) Do you have any comments or suggestions on this idea? Thank you!

lingyuncai avatar Dec 18 '24 02:12 lingyuncai

Could you try kicking off the try-jobs again?

camillobruni avatar May 21 '25 13:05 camillobruni

Deploy Preview for webkit-speedometer-preview ready!

Name Link
Latest commit 1411d4a1e252018dc450f7d898f517b647c97e40
Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/682e7cccde06850008775df0
Deploy Preview https://deploy-preview-454--webkit-speedometer-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar May 22 '25 01:05 netlify[bot]

Hi @camillobruni, I just did a rebase and triggered a new round of CI runs.

lingyuncai avatar May 22 '25 01:05 lingyuncai