Speedometer icon indicating copy to clipboard operation
Speedometer copied to clipboard

Add complexity param

Open camillobruni opened this issue 1 year ago • 6 comments

Depends on params.mjs changes in #469

Work in progress proposal for adding a variable complexity param.

  • complexity === 1.0: workloads run in default configuration
  • complexity > 1.0: ideally workloads run proportionally slower
  • complexity < 1.0: ideally workloads run proportionally fast

Background: We're occasionally seeing issues with gc timing / optimisations heuristics with the current workloads. If we can dynamically change the duration / complexity of workloads it's a bit easier to assess how good these heuristics are and how much we're potentially overfitting.

Current Limitations:

  • DeveloperMode UI cannot reload tests.mjs causing stale BenchmarkTestStep titles
  • Only TodoMVC are currently scaling the workload size (other workloads are depend on whether we're fine with the general idea here)

camillobruni avatar Oct 09 '24 14:10 camillobruni

Without looking closely at the code change, I think this is a neat idea and I could imagine us increasing the complexity of charts, text editing, etc if we move forward with it. Will be curious for feedback from @julienw.

bgrins avatar Oct 10 '24 03:10 bgrins

  • Only create new Params object if there are URL search params
  • Added table to highlight non-standard params if there are is a default to the defaultParams object Screenshot 2024-10-11 at 14 15 17

camillobruni avatar Oct 11 '24 18:10 camillobruni

I've now changed the complexity slider to have an exponential scale which makes it a bit more comfortable to use.

camillobruni avatar Dec 10 '24 19:12 camillobruni

Deploy Preview for webkit-speedometer-preview ready!

Name Link
Latest commit 57b131bf2af561caaa42ab2e68c321f912374c9f
Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/6863e3948933a30008fe5abc
Deploy Preview https://deploy-preview-430--webkit-speedometer-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar May 21 '25 12:05 netlify[bot]

We should probably log all non-standard params to the json file. let me do that in a separate PR. In our infra we use the json file to populate perf data.

camillobruni avatar May 27 '25 14:05 camillobruni

This is ready for review again.

camillobruni avatar Jul 01 '25 13:07 camillobruni