Speedometer icon indicating copy to clipboard operation
Speedometer copied to clipboard

News Site Nuxt

Open flashdesignory opened this issue 1 year ago • 3 comments

This fixes next.js issue for Nuxt: https://github.com/WebKit/Speedometer/issues/422

The fix here is to add unique ids to any article content that is a list. This is done in the actual data files, so no need for the app to generate them at any point.

@kara

flashdesignory avatar Aug 31 '24 12:08 flashdesignory

Do we have before/after numbers?

rniwa avatar Sep 04 '24 03:09 rniwa

I checked just Firefox on my computer, couldn't see any difference.

julienw avatar Sep 04 '24 07:09 julienw

Do we have before/after numbers?

Here's a snapshot:

browser before after
chrome 64.80 63.02
firefox 66.03 67.27
safari 60.47 65.13

flashdesignory avatar Sep 04 '24 11:09 flashdesignory

@rniwa - any concerns to merge this?

flashdesignory avatar Oct 01 '24 19:10 flashdesignory

@rniwa - I did some testing with @camillobruni and here are our crossbench results:

current workload:

browser safari Firefox Google Chrome
duration 61.80 ± 1.5% 66.96 ± 0.72% 66.0 ± 1.8%
score 16.27 ± 1.3% 14.98 ± 0.68% 15.19 ± 1.8%

pr workload:

browser safari Firefox Google Chrome
duration 61.68 ± 0.74% 66.04 ± 1.2% 65.40 ± 1.2%
score 16.31 ± 0.68% 15.18 ± 1.1% 15.33 ± 1.1%

flashdesignory avatar Oct 07 '24 21:10 flashdesignory

closing, in favor of: https://github.com/WebKit/Speedometer/pull/448

flashdesignory avatar Dec 03 '24 17:12 flashdesignory