News Site Next

Open flashdesignory opened this issue 1 year ago • 5 comments

This fixes next.js issue: https://github.com/WebKit/Speedometer/issues/422 A separate pr for Nuxt will do the same.

The fix here is to add unique ids to any article content that is a list. This is done in the actual data files, so no need for the app to generate them at any point.

@kara

Aug 31 '24 11:08 flashdesignory

yes, absolutely! Tests are needed and will come in a future PR at some point.

Sep 02 '24 12:09 flashdesignory

Do we have before/after numbers?

Sep 04 '24 03:09 rniwa

Do we have before/after numbers?

here's a snapshot

browser	before	after
chrome	72.27	70.27
firefox	77.47	72.43
safari	54.03	57.47

Sep 04 '24 11:09 flashdesignory

Is that runtime or pts?

Sep 04 '24 16:09 rniwa

Is that runtime or pts?

we're displaying runtime in the detail screen, right?

Sep 04 '24 16:09 flashdesignory

@rniwa - any concerns to merge this?

Oct 01 '24 19:10 flashdesignory

closing in favor of: https://github.com/WebKit/Speedometer/pull/447

Dec 03 '24 17:12 flashdesignory