Jan Jurzitza

Results 777 comments of Jan Jurzitza

Hm ok but I will keep this open as its still not implemented and if someone else wants to implement it they can do that

yes but it can only open a terminal on mac

I agree the configuration would be cleaner after this change. Not sure about unifying the methods yet. The idea is great, but I don't know if they share enough code...

Hm making those commands more configurable sounds like a good idea

Yes, as config value with the default of `["gdb-set target-async on", "environment-directory \"$(cwd)\"", "target-select remote $(target)"]`. For the variables just use a simple replace and only allow cwd and target...

if you include them in the package.json you need to escape the string like this I think: https://github.com/WebFreak001/code-debug/blob/master/package.json#L305

And yes you need them both in the package.json as well as in the js code by checking for undefined. The package.json default one is the auto completion the user...

See https://github.com/Microsoft/vscode/issues/49389

It would be cool if environment-directory and target-select could also be inside the autorunBeforeCmds array. In line 232 where you only have sendCommand right now you would need to add...

If you need any more help or suggestions, just push the code and I can use the github review feature. I think it's important to add this to SSH too,...