code-debug icon indicating copy to clipboard operation
code-debug copied to clipboard

cleanInvalidSocketPath on start

Open GitMensch opened this issue 2 years ago • 9 comments

start for existing and invalid debugserver sockets and close those

originally done by @chenhaoyang2019 as a side change in fd7d8ee1642b6e29e84667daefd4083c0771af45 at https://gitee.com/openkylin/native-debug.git

Note: this is not verified at all, I mostly wanted to point this change (and fork, which is published as Kylin Native Debug) out and let others review this in more depth.

The parts that are a bit more complex and relevant "upstream" are:

  • assembly debugging (should be mostly fine)
  • stdin in debug console, but that seems to be "local linux only" (so may need a bunch of changes)

... and some unrelated changes like editor tab commands to start/stop recording via GDB (which sadly does not work well on most platforms, is very likely gdb-only, and can be enabled/disabled via debug console).

GitMensch avatar Jun 06 '23 18:06 GitMensch

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (9fb2875) 20.89% compared to head (8b1188c) 20.62%.

Files Patch % Lines
src/mibase.ts 0.00% 25 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   20.89%   20.62%   -0.27%     
==========================================
  Files          14       14              
  Lines        1771     1794      +23     
  Branches      381      387       +6     
==========================================
  Hits          370      370              
- Misses       1356     1379      +23     
  Partials       45       45              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 06 '23 18:06 codecov-commenter

@WebFreak001 Should I rebase and fix the linting issues - or isn't this likely to get merged?

GitMensch avatar Feb 07 '24 06:02 GitMensch

cleaning up at startup sounds like a reasonable idea to me

WebFreak001 avatar Feb 07 '24 06:02 WebFreak001

Not sure what the lint-docs want, when I run prettier on that file, I get the exact same result.

GitMensch avatar Feb 07 '24 08:02 GitMensch

issues in CHANGELOG.md?

WebFreak001 avatar Feb 07 '24 08:02 WebFreak001

looks like my version bump was missing a link when I updated the docs - will fix in master

WebFreak001 avatar Feb 07 '24 08:02 WebFreak001

fixed on master now

WebFreak001 avatar Feb 08 '24 06:02 WebFreak001

Please recheck the changes, if they look good to you now I'll rebase and merge. Thanks!

GitMensch avatar Feb 08 '24 07:02 GitMensch