moment-round

moment-round copied to clipboard

Incompatible with Webpack

10

Hi, super awesome plugin! It fails when compiled with webpack though: ``` WARNING in ./~/moment-round/dist/moment-round.js Critical dependencies: 3:50-57 require function is used in a way in which dependencies cannot be...

jeffijoe

Yeah, it's a weird one. Here's code to reproduce: ```javascript const start = moment.tz('2017-11-01T01:00:00', 'America/Chicago'); const end = moment.tz('2017-11-10T00:55:00', 'America/Chicago'); while (start.isBefore(end)) { start.add(5, 'minutes') .round(5, 'minutes'); this.logger.info(start.format()); } ```...

jamesearl

It currently links to https:\/\/github.com/We __n__ DevTmas/moment-round.

dudeofawesome

Why the rounding functions have to modify the moment object

1

Just curious about the reason why the moment object gets modified after calling floor, ceil or round. What if you want to get both floor and ceil of same moment....

xyz1hang

Hi I would expect these two values to be identical (after rounded/floored/ceiled) but they are not moment(1486434188218).round(86400, 'seconds').valueOf(); moment(1486434158055).round(86400, 'seconds').valueOf(); It's possible I'm missing something but it look like a...

tregoning

Use for loop instead of for in

1

I see a couple pull requests fixing the same issue with array iteration when the array prototype has been extended (#2, #7), so I thought I'd open another one :-)...

lukas-shawford

Incompatible with r.js optimizer

2

Cannot be used with projects which productionize using Requirejs's built in optimizer. The following error in the optimized version: ``` require.js:1Uncaught Error: Module name "moment" has not been loaded yet...

jpuffer