wp-search-with-algolia icon indicating copy to clipboard operation
wp-search-with-algolia copied to clipboard
verified publisher icon WebDevStudios

Update documentation to reflect removal of "blacklist" verbiage.

Open tw2113 opened this issue 3 years ago • 2 comments

Looking at https://github.com/WebDevStudios/wp-search-with-algolia/wiki/Filter-Hooks and we have reference to algolia_post_types_blacklist which got deprecated in favor of algolia_excluded_post_types in version 1.7.0 from the looks of it.

We should review the documentation to update any references to the deprecated "blacklist" wording.

tw2113 avatar Jun 24 '22 23:06 tw2113

I'm getting warning of this in my debug.log file.

[04-Jul-2022 09:02:07 UTC] PHP Deprecated: algolia_post_types_blacklist is <strong>deprecated</strong> since version 1.7.0! Use algolia_excluded_post_types instead.

using WordPress 5.9.3 and PHP 8.0.20

leadoux avatar Jul 04 '22 09:07 leadoux

Hey @leadoux do you have any custom code around WP Search with Algolia being used for your install? If yes, especially around this specific topic, you'll want to update the hook mentioned to match. I've checked the codebase for the plugin itself and the algolia_post_types_blacklist hook is only mentioned in the one spot where we've marked it as deprecated.

tw2113 avatar Jul 05 '22 14:07 tw2113

https://github.com/WebDevStudios/wp-search-with-algolia/wiki/Filter-Hooks is the only wiki page that has it mentioned.

tw2113 avatar Oct 11 '22 21:10 tw2113

Fixed up in https://github.com/WebDevStudios/wp-search-with-algolia/wiki/Filter-Hooks/_compare/a382cc3d7b48433575a63d8915c60f4ca6373818...2e80c65b67ea0aa2560f86e127f868d910b58592

tw2113 avatar Oct 11 '22 22:10 tw2113