custom-post-type-ui icon indicating copy to clipboard operation
custom-post-type-ui copied to clipboard

Consideration: Create jQuery-less version of `/src/js/cptui-scripts.js`

Open tw2113 opened this issue 2 years ago • 6 comments

Is there benefit at the moment to go jQuery-less for our file?

Could it be an exercise in javascript knowhow?

jQuery will likely be around in WordPress admin for a long time yet.

https://github.com/WebDevStudios/custom-post-type-ui/blob/1.13.4/src/js/cptui-scripts.js

tw2113 avatar Mar 10 '23 23:03 tw2113

we do make use of jQueryUI Dialog, so this may not be worth the effort.

tw2113 avatar Apr 10 '23 17:04 tw2113

Closing as wontfix because of the Dialog reliance.

tw2113 avatar May 30 '23 19:05 tw2113

I'm bringing this one back because despite us using jQuery Dialog for some things, we don't need to use jQuery for the other parts of our script.

tw2113 avatar Jan 24 '24 14:01 tw2113

At least once I get some parts figured out, we're also going to move to native <dialog> instead of jQueryUI Dialog as well.

tw2113 avatar Jan 29 '24 14:01 tw2113

At the moment, I'm fine with changing everything that I can manage, but if that means also still relying on jQuery UI Dialog for one small part, I'm good with that. I'd like to get the changes don thus far out the door, and we can always revisit in the future.

tw2113 avatar Mar 12 '24 13:03 tw2113

PR is available at https://github.com/WebDevStudios/custom-post-type-ui/pull/964

tw2113 avatar Mar 12 '24 16:03 tw2113

We have more work to do, so I'm not closing this issue overall yet. We got a good amount of work done already.

See https://github.com/WebDevStudios/custom-post-type-ui/pull/964#pullrequestreview-1964434471 for more discussion about what can be updated/done here.

tw2113 avatar Apr 08 '24 22:04 tw2113