WebDevStudios
Feature Request - Add delete link/option to the 'Registered Types/Taxes' list
Hello,
Just wanted to request the delete functionality be exposed on the 'Registered Types/Taxes' list here with the 'Edit' and 'Get code' links; https://i.imgur.com/WId2AV1.png
Thanks
This one I'm a bit less convinced with, as at least in my mind, those are just quick links to other areas in our supplied admin, and not so much an instant destructive action.
Thanks Michael, in my opinion I'd find the function being exposed there as very helpful as it would reduce the amount of clicks to accomplish the task especially if you have numerous to remove. Cheers
- Would need a nonce
- Should get a popup prompt confirmation.
- Possibly an inline icon related to deleting somehow to add extra warning.
Beyond that, I'm willing to roll with this one at this point.
@iamahless Did you get started with this one at all? or did it get stalled due to other things coming up? Asking because I am curious what you have done as compared to @alokstha1 and if there's any overlap going on.
@tw2113 I believe @iamahless is busy with other things. So, I took over. I'll push the progress probably by the end of the day or tomorrow.
@alokstha1 has anything been done with this one yet, or is it still pending any work? Asking because I may take it on myself since I want it part of the 1.13.0 release.
Bumping this to 1.14.0 as i want to get what we have so far and also a new reported issue out the door
Due to how I'm picturing #891 going, this may actually become a key component in that, and needed.
We'll want to make sure that deleting in this fashion will NOT do any writing to the local JSON files from #891, so that we don't require restoring backups or resetting those files back to previous commits.
Sorry Alok, but I moved everything to 687-add-delete-link-two branch. Keeping what I can for your contributions, but ended up changing direction a fair amount.
This branch still needs to add modal popup confirmation for deleting.
It also needs to be tested with #891 to to help make sure that we're not deleting the JSON file when deleting in this method. I think as is we would be. We may need a flag inside cptui_delete_post_type and cptui_delete_taxonomy to prevent deleting, somehow. TBD.
Hey @garretthyder Would love for a touch of extra testing from you if you're willing. Below is a link to a release build that should be install-ready with the current state of this release functionality in place.
Hey @garretthyder Sorry for sort of "falling off the radar" here, it was all vacation time I promise :D
Did you have a chance to test this feature out at all?
Going to close this task as finished, as it's been merged into the branch for Local JSON integration, which is still slated for 1.14.0 as well.
Sorry @tw2113 I did the same, hope you enjoyed yours. We got to the artic circle to see Polar Bears in Churchill.
Got a chance to review, code looked good. Tested well too. Only comments are minor improvements that can be future iterations.
-
On the table 'Delete' it would be nice to mark it red to match the wp convention for a potentially dangerous action; #b32d2e See other row tables in wp that use trash/delete.
-
Similar on the Edit screen the Delete button might do with being marked red or made into a link to match WP convention.
-
Notices should end in periods to make them sentences.
Everything works great though, those are all just minor aesthetics.
All the best
Noted and definitely good feedback. Thanks.
Sounds like that was a wonderful trip too!