WDS-Active-Plugin-Data icon indicating copy to clipboard operation
WDS-Active-Plugin-Data copied to clipboard

siteurl instead of domain

Open GutHib opened this issue 8 years ago • 6 comments

Hi,

Nice little plugin you wrote there. Just a small suggestion - in line 253, you are using $site->domain to come up with an identifier for each site, but at least for me, that just gets you the main domain every time. $site->siteurl does the trick.

Thanks!

GutHib avatar Apr 30 '17 13:04 GutHib

Interesting. At the same time though, the only part we use that for is a title attribute, which arguably could also be a candidate for removal as a whole.

tw2113 avatar Apr 30 '17 19:04 tw2113

Yeah, but it's actually quite useful, because if you couldn't hover over the numbers to have your URL displayed, how could you easily figure out which column relates to which site?

GutHib avatar Apr 30 '17 19:04 GutHib

Output that info as part of the link text. Been too long since I looked at the actual output to see if that'd break a lot of visual layout and whatnot. Just throwing the thought out there.

tw2113 avatar Apr 30 '17 19:04 tw2113

I think you decided against that to keep the columns slim. If you put more than a number, I would assume it indeed breaks the layout.

GutHib avatar Apr 30 '17 19:04 GutHib

Probably. Regardless, make whatever changes you need to make it work for you. PRs welcome as well.

tw2113 avatar Apr 30 '17 19:04 tw2113

Already did that. Just mentioned it in case somebody wants to incorporate it as a fix into the "official" script. Not worth the hassle to make my own commit, since I'm not a dev nobody is gonna use that, ever.

GutHib avatar Apr 30 '17 19:04 GutHib