Micah Hoffman comments

Results 85 comments of


                                            Micah Hoffman

Alter JSON format

PR #477 contains the [wmn-data.json](https://github.com/WebBreacher/WhatsMyName/blob/main/wmn-data.json) file in the new format. TODO - 1. Update checker scripts to use it 2. Update JSON validator GitHub Action

Alter JSON format

PR #478 Adds the new JSON schema file and updates the JSON validator GitHub Action

Alter JSON format

@Unpublished - GitHub Action to minify code is in place and auto-generating the `wmn-data-min.json` and `web_accounts_list-min.json` files per your suggestion.

Alter JSON format

Not sure how I/we missed that. Yes both `m_code` and `e_code` can/will be changed to integers instead of strings.

Alter JSON format

Commit https://github.com/WebBreacher/WhatsMyName/commit/c609d0ab6d09c8650d2fb1a436c4e9454bd760ac addresses this @yooper

Alter JSON format

> Should new pull requests modify both `web_accounts_list.json` and `wmn-data.json` for now? Yes.

Create new Python checker script

Altered issue wording using parameters consistent with #414

Create new Python checker script

@yooper 1. Yes to the async threading (see Additional requirements, bullet 4 above) 2. I'm not looking for an interactive CLI here just `python whatsmyname.py -u webbreacher -i inputfile.json -o...

Create new Python checker script

This issue is an ask for the entire new checker script to replace the existing two and having all the above features not just the async calls). That brach was...

Create new Python checker script

> With the new checker scripts are you fine with moving to a more modular approach so its easier to write unit tests against the functionality? **Yes** > Re: Docker...