preserve ModuleItem location information

[yuri91]

I am using wasp for a project, and I realized that when iterating a text module, I can't get the location information from the ModuleItems

The issue is an extra unneeded dereference operation:

When constructing a ModuleItem from the actual item (function, import, ...) the original At<> was unwrapped by the dereference operator, and then the conversion operator of At would wrap the item again (because ModuleItem actually wants an At<> as variant member), but with a default location with an empty span.

[binji]

Good catch! This also needs some read_test.cc fixes, which are a bit clumsy to resolve, unfortunately. Here's the patch that I made locally that fixes those issues: read_test.zip

[yuri91]

Ah right, I didn't run the tests.

I applied your patch (thanks!) and they pass now

[binji]

I think this is working, but CI is blowing up for a different reason.