wasi-sdk icon indicating copy to clipboard operation
wasi-sdk copied to clipboard

Avoid extra Cargo installation artifacts

Open abrown opened this issue 1 year ago • 2 comments

As @bjorn3 mentioned in #420, using --no-track should get rid of the extra files that show up after the cargo install. Fixes #420.

abrown avatar Jun 28 '24 01:06 abrown

I haven't yet verified this works but wanted to do this before I forget.

abrown avatar Jun 28 '24 01:06 abrown

I tried this out locally and the build failed for other reasons!

$ NINJA_FLAGS=-v make package
...
/.../wasi-sdk/build/install/opt/wasi-sdk/bin/llvm-ar crs build/wasm32-wasi/libc.so.a 
/.../wasi-sdk/build/install/opt/wasi-sdk/bin/clang --target=wasm32-wasi -nodefaultlibs -shared --sysroot=/.../wasi-sdk/build/install/opt/wasi-sdk/share/wasi-sysroot \
-o /.../wasi-sdk/build/install/opt/wasi-sdk/share/wasi-sysroot/lib/wasm32-wasi/libc.so -Wl,--whole-archive build/wasm32-wasi/libc.so.a -Wl,--no-whole-archive /.../wasi-sdk/build/install/opt/wasi-sdk/lib/clang/18/lib/wasi/libclang_rt.builtins-wasm32.a
wasm-ld: warning: creating shared libraries, with -shared, is not yet stable
wasm-ld: error: duplicate symbol: accept
>>> defined in build/wasm32-wasi/libc.so.a(accept.pic.o)
>>> defined in build/wasm32-wasi/libc.so.a(accept-wasip1.pic.o)

wasm-ld: error: duplicate symbol: accept4
>>> defined in build/wasm32-wasi/libc.so.a(accept.pic.o)
>>> defined in build/wasm32-wasi/libc.so.a(accept-wasip1.pic.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile:587: /.../wasi-sdk/build/install/opt/wasi-sdk/share/wasi-sysroot/lib/wasm32-wasi/libc.so] Error 1
make[1]: Leaving directory '/.../wasi-sdk/src/wasi-libc'
make: *** [Makefile:150: build/wasi-libc.BUILT] Error 2

I wonder if something is failing in the build that is being masked by our action caching?

abrown avatar Jun 28 '24 21:06 abrown