wasi-libc icon indicating copy to clipboard operation
wasi-libc copied to clipboard

Published 20 hours ago • verified publisher icon WebAssembly

adjust S_IFIFO to avoid collisions

Open vapier opened this issue 5 years ago • 7 comments

S_IFIFO currently has the same value as S_IFSOCK which breaks code that does things like "switch (mode & S_IFMT)" as we end up with duplicate labels. Move S_IFIFO to a unique unused value.

vapier avatar Oct 12 '19 04:10 vapier

i guess more importantly, the current defines make it impossible to differentiate between fifos & sockets :)

vapier avatar Oct 12 '19 17:10 vapier

all of that sounds fine. i'll try to tackle it when i get a chance. thx!

vapier avatar Oct 16 '19 18:10 vapier

i posted https://github.com/WebAssembly/WASI/pull/189 to add FIFO filetype

vapier avatar Jan 01 '20 09:01 vapier

my WASI PR is merged now. was there something else needed here before merging?

vapier avatar Jan 09 '20 10:01 vapier

Before we merge changes into wasi-libc which WASI implementations will need to support, we'll need the WASI Subgroup to publish a new snapshot. There isn't a specific schedule for that yet, but it hopefully won't be too long.

sunfishcode avatar Jan 09 '20 15:01 sunfishcode

i think a new snapshot has been posted by now ? so can we merge ?

vapier avatar Sep 30 '20 20:09 vapier

Unfortunately no, we have not published a new snapshot yet. Snapshot 2 is set to include modularization, which requires updates to the witx tooling, which is not finished yet. Hopefully once we're past this milestone, subsequent snapshots can be published more frequently.

sunfishcode avatar Sep 30 '20 23:09 sunfishcode