wabt icon indicating copy to clipboard operation
wabt copied to clipboard

Allow Code Metadata Annotations to have arbitrary hex strings

Open jabraham17 opened this issue 2 years ago • 0 comments

This PR adds support for arbitrary hex strings in code metadata annotations. Previously, the decoded strings would be checked as utf-8 strings. However, this prohibits something like (@metadata.code.trace_inst "\FF\FF") since 0xffff is not a valid utf-8 string.

Also modified existing roundtrip test to have a string that includes a non-utf8 character

jabraham17 avatar Mar 31 '22 17:03 jabraham17

Thank you -- merging as this was approved and also lgtm.

keithw avatar Aug 16 '22 19:08 keithw