spec icon indicating copy to clipboard operation
spec copied to clipboard

[test] introduce script scopes around expensive memory tests

Open rossberg opened this issue 2 years ago • 2 comments

Fix #1698. This tweaks the generators for bulk memory/table tests to insert (script ...) scopes around tests and extends the JS converter to turn these into block scopes.

This is likely to break existing .wast consumers that do not recognise script scopes. The simplest fix is to ignore them by treating them as equivalent to their contents.

rossberg avatar Oct 27 '23 13:10 rossberg

Does it help to split up these tests into multiple .wasts? In general, splitting up the many large spec tests helps ergonomics of the test suite.

titzer avatar Oct 27 '23 14:10 titzer

Personally, I'm not a big fan of having a gazillion micro test files. But in any case, these are generated, so that would require a more significant rewrite of the JS generator scripts, that somebody would have to volunteer doing.

rossberg avatar Oct 27 '23 18:10 rossberg