component-model icon indicating copy to clipboard operation
component-model copied to clipboard

Comments/Questions

Open rossberg opened this issue 2 years ago • 1 comments

I finally did an end-to-end read of all (well, most of) the docs in this repo. Since GH doesn't offer a means to comment on committed files, I created a dummy repo with a dummy PR of the entire content here and left my comments & questions there. Hope that indirection works well enough. :)

Overall, this looks great. I found the explainer particularly helpful and very well-written.

Happy to open individual issues for some of my comments/suggestions if they turn out to be relevant.

rossberg avatar Nov 29 '23 11:11 rossberg

Awesome, thanks so much! I'll definitely go through the comments and either turn them into PRs or ask questions here or open new issues, as appropriate.

lukewagner avatar Nov 29 '23 18:11 lukewagner

Oops, this fell off my radar, but I started going through all the comments just now. I started with a first pass that simply fixes typos in this commit. For the rest, I'll submit some PRs so they can be reviewed.

lukewagner avatar Apr 11 '24 18:04 lukewagner

Ok, I went through all the comments and either replied inline or folded the feedback into #339 or #341. Happy to discuss more inline in those comment threads or on the above PRs or here.

lukewagner avatar Apr 13 '24 21:04 lukewagner

Thanks, I left a few more replies.

rossberg avatar Apr 16 '24 07:04 rossberg

(Also filed #351.)

lukewagner avatar Apr 30 '24 22:04 lukewagner

Ok, with #353 filed, I think I've gone through all the comments. Thanks a lot for all the feedback and suggestions!

lukewagner avatar May 06 '24 20:05 lukewagner

Great, thanks for filing #356 for discussion. I'll close this issue b/c I think that's everything, but feel free to reopen if there's anything missing, or file new issues.

lukewagner avatar May 08 '24 17:05 lukewagner