binaryen icon indicating copy to clipboard operation
binaryen copied to clipboard

Move `auto_update_tests.py` into scripts directory. NFC

Open sbc100 opened this issue 2 years ago • 2 comments

So it lives alongside update_lit_checks.py and update_help_checks.py

sbc100 avatar Aug 05 '22 16:08 sbc100

Hmm, makes sense, but then maybe check.py also makes sense to move - then we'd have no scripts in the top level.

The current state before this PR also makes sense to me, of having just the 2 main scripts there: check and update (and all their helpers are in subdirs).

But I don't feel strongly here.

kripken avatar Aug 05 '22 18:08 kripken

I think its ok to keep check.py at the top level for now.. but I also don't feel strongly. @tlively what do you think? Ok to land this as is or should I move check too?

sbc100 avatar Aug 05 '22 19:08 sbc100

I don't feel too strongly. I think it would be fine to move auto_update_tests.py to scripts/ and keep check.py where it is. It would be great to document auto_update_tests.py in the README, though. Now that it's not in the top directory, it's less discoverable.

tlively avatar Aug 10 '22 22:08 tlively

Updated the README to point to the two different auto-update scripts.

sbc100 avatar Aug 12 '22 01:08 sbc100

OK to land this now, with the documentations changes?

sbc100 avatar Aug 12 '22 01:08 sbc100