binaryen icon indicating copy to clipboard operation
binaryen copied to clipboard

Missing 64-bit AtomicCmpxchg causes `__sync_fetch_and_nand` to fail under wasm2js

Open sbc100 opened this issue 4 years ago • 2 comments

Usage of __sync_fetch_and_nand with 64-bit operands in emscripten causes the following error:

wasm2js: /usr/local/google/home/sbc/dev/wasm/binaryen/src/passes/I64ToI32Lowering.cpp:471: void wasm::I64ToI32Lowering::visitAtomicCmpxchg(wasm::AtomicCmpxchg *): Assertion `curr->type != Type::i64 && "64-bit AtomicCmpxchg not implemented"' failed.

I think this is probably super rare and not a huge deal, but creating this issue so I can link to it in the test code.

sbc100 avatar Nov 24 '21 01:11 sbc100

@kripken should we care about this?

sbc100 avatar May 17 '24 16:05 sbc100

I don't think I heard of this affecting real-world code, so it seems like a very low priority to me.

kripken avatar May 17 '24 17:05 kripken