web-dev-path icon indicating copy to clipboard operation
web-dev-path copied to clipboard

Feature/add theming

Open LuSilvaDeveloper opened this issue 1 year ago • 1 comments

Web Dev Path
165

Have you updated the CHANGELOG.md file? If not, please do it.

Yes.

What is this change?

Adding theming to the project to have centralized all SASS variables previously spread across _mixins.js and _variables.js into themeConfig.js for better organization.

Some questions:

  • We have some components that were using both SASS and normal CSS, for example, inside styles.js from Hero we have the HeaderContent which was previously using SASS for color and normal CSS for padding-top. The best approach should be keeping the of padding-top inside the styles.js file, and color we keep it inside themeConfig.js?
Screenshot 2024-01-16 at 6 40 12 AM
  • Should we pass all attributes inside globals.scss to themeConfig.js on GlobalStyles or should we keep only the attributes that were using SASS inside themeConfig.js, similarly to the previous question?
Screenshot 2024-01-16 at 6 50 00 AM Screenshot 2024-01-16 at 6 50 20 AM

The next step would be passing these attributes to all components, making sure everything is working.

Were there any complications while making this change?

Mostly misunderstanding on my part regarding the issue

How to replicate the issue?

Run on different browsers.

If necessary, please describe how to test the new feature or fix.

NA

When should this be merged?

LuSilvaDeveloper avatar Jan 16 '24 14:01 LuSilvaDeveloper

Deploy Preview for webdevpathstage ready!

Name Link
Latest commit 5c955e39ff79ee342af58191546674636a14d561
Latest deploy log https://app.netlify.com/sites/webdevpathstage/deploys/664d7a50690ab600087be749
Deploy Preview https://deploy-preview-210--webdevpathstage.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 16 '24 14:01 netlify[bot]