m2-module-import icon indicating copy to clipboard operation
m2-module-import copied to clipboard
verified publisher icon WeareJH

PHP Codesniffer pass

Open pbritka opened this issue 3 months ago • 0 comments

I run php codesniffer and it couldn't pass the Magento2 technical review. I added proper output escaping, replaced md5 with sha256 and fixed

  • previously removed preference for Symfony\Component\Console\Output\OutputInterface which made it unable to run the import from cli
  • fixed action that downloaded csv files from admin import configuration detail

The code still doesn't pass the technical review as it doesn't use db_schema.xml, but I saw another pull request that fixes this problem

pbritka avatar Sep 16 '25 20:09 pbritka