WeakAuras2 icon indicating copy to clipboard operation
WeakAuras2 copied to clipboard

Additional Progress Texture Conditions Properties

Open anaseskyrider opened this issue 7 years ago • 3 comments

Add more settings from Progress Textures, Crop X/Y and Rotation in particular, to Conditions.

anaseskyrider avatar Jan 01 '19 00:01 anaseskyrider

Rotation is done via a Animation. While not impossible to add that to conditions, the interaction might not be exactly what is expected, thus it needs a good reason to add it.

For Crop X/Y you'd have to explain the use case for changing it via a condition.

InfusOnWoW avatar Jan 01 '19 00:01 InfusOnWoW

In my case, I'm using a TSU to clone a progress texture, and I'm using animations and conditions to update the various properties of the texture -- like the actual texture and its positioning. Its use is for tracking spell CDs, charges, and associated auras -- the goal being to make something with a bit more flavor and color while being less intrusive than icons, and while being condensed into one WeakAura per spell.

If I'm changing the texture, then given the way that Progress Textures works, I may sometimes have to update the crop to get the progress feature to function correctly.

anaseskyrider avatar Jan 01 '19 00:01 anaseskyrider

After giving this some thought, this is not going to be a trivial addition and thus will not come quickly.

There are a few things that need to be considered and designed:

  • As you note (and I agree) the crop paramter depend on the texture. That means that the crop (and recenter) parameter should be customizable in the "same" way as the texture. Meaning integrating it into a state property/custom texture function would be the right way to do it.

  • It's not immediately clear whether the parameters are best provided via crop/recenter or via more generic tex coord setting. I'm more leaning towards tex coords, since that's more general

  • A tex coord setting would also allow rotation, so how that interacts with the existing rotation settings needs to be figured out.

  • With that said, I kind like the idea of controlling both texture and tex coords via a condition, as that feels very natural. How that should interact with the existing custom texture function/state.texture and the texture set on the display tab is not clear to me.

  • And last, there's a open ticket for controlling the icon via a condition. Icons are somewhat similar to textures in that some triggers provide the necessary information, and there's a "manual" setting for these. Though the two differ in what way the manual and the trigger provided information interact. That's unfortunate too.

InfusOnWoW avatar Jan 02 '19 23:01 InfusOnWoW