roadmaps icon indicating copy to clipboard operation
roadmaps copied to clipboard

Added more Frontend projects you can contribute

Open soumil1 opened this issue 1 year ago • 1 comments

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

soumil1 avatar Jul 02 '23 07:07 soumil1

https://github.com/WeMakeDevs/roadmaps/issues/584#issue-1783780442

soumil1 avatar Jul 02 '23 07:07 soumil1

I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well.

AnuragThePathak avatar Jul 04 '23 12:07 AnuragThePathak

Hey, @soumil1 it seems you might have edited all the existing resources as well. We are unable to figure out which ones were added by you. Either recreate a branch and re-commit the changes and open a new PR or you can mention the resources which you have added

siddhant-khisty avatar Jul 04 '23 14:07 siddhant-khisty

Hey, @soumil1 it seems you might have edited all the existing resources as well. We are unable to figure out which ones were added by you. Either recreate a branch and re-commit the changes and open a new PR or you can mention the resources which you have added

Hey, @siddhant-khisty sorry from my end. Actually, on the first line, I mistakenly changed "## - 2nd level heading" to "# - 1st level" on Open Source Frontend projects to which you can contribute, which made it appear as if I had changed the entire Readme, but I haven't. I only added the "Gatsby" and "Twbs Bootstrap" links

soumil1 avatar Jul 04 '23 14:07 soumil1

I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well.

Can I mention the new changes I made to the description now?

soumil1 avatar Jul 04 '23 14:07 soumil1

I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well.

Can I mention the new changes I made to the description now?

Yes

siddhant-khisty avatar Jul 04 '23 15:07 siddhant-khisty

I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well.

Can I mention the new changes I made to the description now?

Yes

Edited the description. Can you please check

soumil1 avatar Jul 04 '23 15:07 soumil1

Hey, @soumil1 these projects that you've included do not really fit under the frontend category. Imo they would be better suited as backend projects. Yes they are frontend frameworks, but a contributor would need a good amount of frontend as well as backend knowledge to contribute to them. I could be wrong tho. @AnuragThePathak @kaiwalyakoparkar what are your opinions on this issue?

siddhant-khisty avatar Jul 07 '23 17:07 siddhant-khisty

Bootstrap one is frontend ig and Gatsby too (but these are not web apps, except the Bootstrap website).

AnuragThePathak avatar Jul 07 '23 19:07 AnuragThePathak

So what do I do now? @siddhant-khisty @AnuragThePathak
Can I create a new pull request and update both of these links in backend development?

soumil1 avatar Jul 08 '23 09:07 soumil1

@soumil1 The bootstrap is one fine I guess. But please move the gatsby one to backend. You can simply push more commits to this branch to update this PR as well

siddhant-khisty avatar Jul 08 '23 11:07 siddhant-khisty

@soumil1 please fix the merge conflicts and we can merge

siddhant-khisty avatar Jul 08 '23 14:07 siddhant-khisty

Sorry for causing a problem. I accidentally force-pushed the commit instead of deleting the conflicts. Is there any way to recover from this disaster :( @siddhant-khisty

soumil1 avatar Jul 08 '23 16:07 soumil1

Do you still have the commits with you? If yes we can recover from the disaster.

AnuragThePathak avatar Jul 08 '23 19:07 AnuragThePathak