Jotoba icon indicating copy to clipboard operation
Jotoba copied to clipboard

Include JLPT tag in API word search result

Open Nyankoo opened this issue 2 years ago • 6 comments

Is your feature request related to a problem? Please describe. When using the API, found words don't include their JLPT tag while they're displayed on the website search

Describe the solution you'd like The "words" json entry should contain the JLPT tag of that word

Describe alternatives you've considered

Additional context

Nyankoo avatar May 05 '22 10:05 Nyankoo

I agree. I've already encountered this issue but unfortunately I don't want to change the API since it could break existing programs. I'm going to add a new version of the API which will include the JLPT information.

JojiiOfficial avatar May 05 '22 10:05 JojiiOfficial

Thank you for the quick reply and I'm looking forward to it!

Nyankoo avatar May 05 '22 10:05 Nyankoo

@JojiiOfficial Just quickly checking in on the progress of this.

Nyankoo avatar Jul 07 '22 22:07 Nyankoo

This is currently out of scope. There is a new, undocumented, API which you could use but this can be changed later at any time. For a V2 I'd like to wait and collect more data that will be included in the new API version so we don't have to change the API all the time.

JojiiOfficial avatar Jul 18 '22 11:07 JojiiOfficial

I came here to suggest the very same thing :D

I also wanted to suggest including the "main" example sentence that appears when you search for a term in the API search results.

Either that OR tag/sort the results returned when calling /api/search/sentences, so we can grab the "top" sentence. Right now, the sentences on the main search results aren't even guaranteed to be in that list, I realized. (Try searching via the API for , for example.)

I'd be happy to file a separate issue for this request if you'd prefer!

Separately, I also wanted to say: thank you for jotoba! It's awesome.

keithfancher avatar Mar 14 '24 21:03 keithfancher

Oh, I just found the trello board... I guess we're on the same page :smile:

Screenshot from 2024-03-14 14-36-38

keithfancher avatar Mar 14 '24 21:03 keithfancher