NonFungibleTime icon indicating copy to clipboard operation
NonFungibleTime copied to clipboard

feat/ERC721 permit

Open leonardishere opened this issue 3 years ago • 3 comments

#88 #155

Use this in the frontend to generate signatures https://github.com/WeAreNewt/NonFungibleTime/blob/03e291d45e209bad24bddef04126cf926e836ffa/packages/contracts/test/utilities/getErc721PermitSignature.ts#L7-L14

leonardishere avatar Feb 11 '22 04:02 leonardishere

✔️ Deploy Preview for elated-kalam-a67780 ready!

🔨 Explore the source changes: ea6c7a11444b4bb87fee3a2e422b638881b8d891

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-kalam-a67780/deploys/620cee54cb13cd0008375374

😎 Browse the preview: https://deploy-preview-161--elated-kalam-a67780.netlify.app

netlify[bot] avatar Feb 11 '22 04:02 netlify[bot]

So I had a bit of a misunderstanding on the contracts side 😓 , I thought approve/permit was required for all NFTs transfers but safeTransferFrom allows the owner to transfer without approval.

What kind of uses cases would this enable @leonardishere? And does it still make sense to add this if we aren't going to directly use this on our frontend?

Setting up a gasless secondary market is what came to mind for me, but I'm not sure that we need to support this since there would be no royalty generated from these transactions

defispartan avatar Feb 11 '22 22:02 defispartan

So I had a bit of a misunderstanding on the contracts side sweat , I thought approve/permit was required for all NFTs transfers but safeTransferFrom allows the owner to transfer without approval.

What kind of uses cases would this enable @leonardishere? And does it still make sense to add this if we aren't going to directly use this on our frontend?

Setting up a gasless secondary market is what came to mind for me, but I'm not sure that we need to support this since there would be no royalty generated from these transactions

It's simply an ERC721 equivalent of https://eips.ethereum.org/EIPS/eip-2612. Someone else could give a better write up of its benefits but secondary markets would probably get the most benefit. I haven't checked the gas costs for the added functionality but it shouldn't be too crazy.

leonardishere avatar Feb 12 '22 04:02 leonardishere