rsync
rsync copied to clipboard
Fix --open-noatime option not working on files
Atime of source files could sometimes be overwritten even though --open-noatime option was used.
Simple script to reproduce:
Version tested: 3.4.1
mkdir src
mkdir dst
echo content > src/file
stat src/file
sleep 1
rsync --open-noatime --archive --atimes src/ dst/
stat src/file
Result:
File: src/file
Size: 8 Blocks: 8 IO Block: 4096 regular file
Device: 259,7 Inode: 9178482 Links: 1
Access: (0664/-rw-rw-r--) Uid: ( 1000/ qrees) Gid: ( 1000/ qrees)
Access: 2025-01-27 17:04:36.936188754 +0100
Modify: 2025-01-27 17:04:36.936188754 +0100
Change: 2025-01-27 17:04:36.936188754 +0100
Birth: 2025-01-27 17:04:36.936188754 +0100
sending incremental file list
delta-transmission disabled for local transfer or --whole-file
file
total: matches=0 hash_hits=0 false_alarms=0 data=8
sent 136 bytes received 105 bytes 482.00 bytes/sec
total size is 8 speedup is 0.03
File: src/file
Size: 8 Blocks: 8 IO Block: 4096 regular file
Device: 259,7 Inode: 9178482 Links: 1
Access: (0664/-rw-rw-r--) Uid: ( 1000/ qrees) Gid: ( 1000/ qrees)
Access: 2025-01-27 17:04:37.940194021 +0100
Modify: 2025-01-27 17:04:36.936188754 +0100
Change: 2025-01-27 17:04:36.936188754 +0100
Birth: 2025-01-27 17:04:36.936188754 +0100
Expected source file atime not to change.
It seems like the bug was introduced in 0590b09d9a34ae72741b91ec0708a820650198b0
@tridge Can you have a look at this? Or at least approve workflows? Thanks you.
@carenas I've expanded the commit message