rsync icon indicating copy to clipboard operation
rsync copied to clipboard

configure.ac: fix failing IPv6 check due to missing return type

Open bobrik opened this issue 2 years ago • 3 comments

Fixing this warning escalated to an error, resuting in no IPv6 support:

configure.sh:7679: checking whether to enable ipv6
configure.sh:7718: clang -o conftest -g -O2 -DHAVE_CONFIG_H -Wall -W   conftest.c  >&5
conftest.c:73:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
main()
^
int
1 error generated.
configure.sh:7718: $? = 1
configure.sh: program exited with status 1

bobrik avatar Jan 02 '24 03:01 bobrik

It was a warning on clang-15, but it is an error on clang-16:

  • https://github.com/NixOS/nixpkgs/pull/278184

bobrik avatar Jan 02 '24 04:01 bobrik

A similar thing happened to curl: https://github.com/curl/curl/pull/12607

bobrik avatar Jan 02 '24 07:01 bobrik

I'm happy to pull the curl's version verbatim if you think that's better.

bobrik avatar Jan 02 '24 07:01 bobrik

@bobrik looks good, thanks!

tridge avatar Apr 06 '24 20:04 tridge