rsync icon indicating copy to clipboard operation
rsync copied to clipboard

configure.ac: use pkg-config to retrieve openssl dependencies

Open ffontaine opened this issue 2 years ago • 5 comments

Use pkg-config to retrieve openssl dependencies such as -latomic and avoids the following build failure when building statically on architectures such as sparc:

/home/autobuild/autobuild/instance-1/output-1/host/lib/gcc/sparc-buildroot-linux-uclibc/10.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /home/autobuild/autobuild/instance-1/output-1/host/sparc-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(threads_pthread.o): in function `CRYPTO_atomic_add': threads_pthread.c:(.text+0x208): undefined reference to `__atomic_is_lock_free'

Fixes:

  • http://autobuild.buildroot.org/results/49abbaa1eab94b248bff434b40728065d687e278

Signed-off-by: Fabrice Fontaine [email protected]

ffontaine avatar Jan 01 '23 17:01 ffontaine

Do you have some comments on this PR?

ffontaine avatar Dec 19 '23 14:12 ffontaine

Thanks for your feedback.

Patch has been applied in buildroot since February (https://git.buildroot.net/buildroot/commit/?id=e889a1c9e983753dd0fa5062d3b9475a8cba6072) and no build failures are raised by autobuilders since that time.

It should be noted that configure must be rebuilt (thanks to autoreconf ) after applying this patch. which updates configure.ac. Could you also try to add PKG_PROG_PKG_CONFIG before PKG_CHECK_MODULES? This macro will check if pkg-config is available on your system.

ffontaine avatar Apr 07 '24 08:04 ffontaine

@ffontaine it was fine after "make reconfigure". Note sure why autoconf didn't generate a good configure script for me yesterday. It's been many years since I worked with autoconf - about 20 years in fact, when I handed over to Wayne :-)

tridge avatar Apr 07 '24 21:04 tridge

@WayneD I'm happy with this

tridge avatar Apr 07 '24 21:04 tridge

Hey @tridge, @WayneD can we have this merged, please?

vilkov avatar May 29 '24 21:05 vilkov