wf-shell icon indicating copy to clipboard operation
wf-shell copied to clipboard

[wf-panel] Lags after hiding

Open NamorNiradnug opened this issue 2 years ago • 10 comments

Seems like the window isn't being rerendered after being hidden and losing focus.

https://github.com/WayfireWM/wf-shell/assets/50048443/466fb206-0a0b-458d-8fa7-48fb62f89d7e

NamorNiradnug avatar Oct 08 '23 20:10 NamorNiradnug

Is this a regression?

ammen99 avatar Oct 08 '23 21:10 ammen99

Is this a regression?

Yes, it started to happen after I updated Wayfire to 0.8 from 0.7.5

NamorNiradnug avatar Oct 08 '23 21:10 NamorNiradnug

My thoughts as well, maybe bisect? It could be related to this recent commit.

soreau avatar Oct 08 '23 21:10 soreau

My thoughts as well, maybe bisect? It could be related to this recent commit.

I'm not sure, but I think it was happening before I merged this commit, let me check.

NamorNiradnug avatar Oct 08 '23 21:10 NamorNiradnug

My thoughts as well, maybe bisect? It could be related to this recent commit.

I'm not sure, but I think it was happening before I merged this commit, let me check.

Yes, it behaves like that with and without that commit.

NamorNiradnug avatar Oct 08 '23 21:10 NamorNiradnug

For some reason nothing happens after this queue_draw (at least draw_signal isn't being emitted)

NamorNiradnug avatar Oct 08 '23 21:10 NamorNiradnug

It should be easy to bisect if you can find a good commit. Have you checked WAYLAND_DEBUG output and make sure the exclusive zone is being set as you expect? Also, it could be that something changed on the wayfire side.

soreau avatar Oct 08 '23 21:10 soreau

So, I've found the commit which introduced the bug That's this one commit: https://github.com/WayfireWM/wayfire/commit/7f8004b41a1865a984f251da3e156cd2d6247368

NamorNiradnug avatar Feb 03 '24 21:02 NamorNiradnug

Still as issue with Wayfire 0.9

NamorNiradnug avatar Sep 16 '24 13:09 NamorNiradnug