wf-shell icon indicating copy to clipboard operation
wf-shell copied to clipboard

volume: hide popover after scrolling

Open NamorNiradnug opened this issue 2 years ago • 4 comments

Fixes #177

Tbh, I have no idea how and why it works.

NamorNiradnug avatar Aug 05 '23 10:08 NamorNiradnug

Sounds as if the actual problem is that the timeout in line 107 is not actually set, because the popup grabs input .. Do we actually ever want the popup to stay forever on screen and grab the keyboard? I'd say the popup should always auto-hide after a configurable timeout and never grab the keyboard.

Currently, it grabs the keyboard so that clicking on another view will auto-close the popup (which is actually broken in recent times, I am starting to work on that) - but that won't be a problem at all if we always auto-close after, say, 2 seconds of inactivity.

ammen99 avatar Sep 26 '23 11:09 ammen99

Sounds as if the actual problem is that the timeout in line 107 is not actually set, because the popup grabs input .. Do we actually ever want the popup to stay forever on screen and grab the keyboard? I'd say the popup should always auto-hide after a configurable timeout and never grab the keyboard.

Currently, it grabs the keyboard so that clicking on another view will auto-close the popup (which is actually broken in recent times, I am starting to work on that) - but that won't be a problem at all if we always auto-close after, say, 2 seconds of inactivity.

Sounds like a good feature, but I think it should autohide faster after changing volume level via scrolling or pressing keyboard button because 2 seconds (or whatever, it obviously should be configurable) it too much to simply see the current volume level.

NamorNiradnug avatar Sep 28 '23 14:09 NamorNiradnug

Sounds as if the actual problem is that the timeout in line 107 is not actually set, because the popup grabs input .. Do we actually ever want the popup to stay forever on screen and grab the keyboard? I'd say the popup should always auto-hide after a configurable timeout and never grab the keyboard. Currently, it grabs the keyboard so that clicking on another view will auto-close the popup (which is actually broken in recent times, I am starting to work on that) - but that won't be a problem at all if we always auto-close after, say, 2 seconds of inactivity.

Sounds like a good feature, but I think it should autohide faster after changing volume level via scrolling or pressing keyboard button because 2 seconds (or whatever, it obviously should be configurable) it too much to simply see the current volume level.

A configuration option sounds good ;)

ammen99 avatar Sep 28 '23 15:09 ammen99