wayfire icon indicating copy to clipboard operation
wayfire copied to clipboard

render-manager: Don't call paint when the session is not active

Open soreau opened this issue 1 year ago • 2 comments

When running wayfire on one tty and having clients that damage constantly, switching to another tty causes wayfire to consume 100% cpu. This patch disconnects the paint handler when the session is not active and reconnects it when the session becomes active again.

soreau avatar Aug 28 '24 21:08 soreau

For some reason, I've found that when starting from a tty 'manually', wayfire does not have this problem, even without this patch. However, if I start wayfire with lightdm, the problem happens only after the second switch to tty. Apparently, the session->active variable is not toggled, so it's unreliable anyway.

soreau avatar Aug 29 '24 04:08 soreau

For some reason, I've found that when starting from a tty 'manually', wayfire does not have this problem, even without this patch. However, if I start wayfire with lightdm, the problem happens only after the second switch to tty. Apparently, the session->active variable is not toggled, so it's unreliable anyway.

Well if this fixes some cases I'd say it is still a win :)

ammen99 avatar Aug 29 '24 04:08 ammen99

This was completely fixed by an update to seatd, as far as I can tell. I can not reproduce the issue as of now. Previously, the version was seatd 0.8.0 3e9ef69f1. I do not think this patch is necessary at all now, closing.

soreau avatar Aug 29 '24 19:08 soreau