input.click_method does not appear to have any impact

[dagbdagb]

Describe the bug Changing the value of input.click_method does not have any impact on the actual config

To Reproduce Steps to reproduce the behavior:

1. Change value of click_method under [input] in wayfire.ini 0.6.0 should handle dynamic reconfig. But either I restart wayfire or not, the outcome is the same:
2. libinput list-devices shows the same click_methods whatever value I put in wayfire.ini:

Click methods: *button-areas clickfinger

Pasting text is a major hassle. Would really like to get rid of button-areas.

Expected behavior I expect the output of 'libinput list-devices' to reflect the wayfire config. Also, the libinput doc states that this attribute is a pair of bools. Hence, click_methods. Plural.

Wayfire version 0.6.0 as installed by gentoo.

[travankor]

Can you reproduce this on sway?

I don't think this is a bug. From the manpage:

For options that allow more settings than "enabled/disabled", all
available ones are listed. The default setting is prefixed by an
asterisk (*).

[dagbdagb]

Allow me to ask this: What is the intended purpose of the setting input.click_method ?

[travankor]

I think you misunderstand: libinput has a setting called default; this is demarcated with an asterisk and is decided by libinput/your driver

wayfire lets you override the default and pick your own setting. (wayfire wont change libinput settings or libinput's default though)

[dagbdagb]

Setting input.click_method to clickfinger, has no impact whatsoever?

In the meantime, I have patched libinput with a quirk for my touchpad, such that the default is clickfinger.

[ammen99]

@dagbdagb is your device properly recognized as a touchpad? Maybe that's the problem, https://github.com/WayfireWM/wayfire/blob/master/src/core/seat/pointing-device.cpp#L69

[dagbdagb]

I don't see any attributes in 'libinput list-devices' which obviously maps to "libinput_device_config_tap_get_finger_count". should I expect one?

Device: Logitech Rechargeable Touchpad T650 Kernel: /dev/input/event15 Group: 5 Seat: seat0, default Size: 123x103mm Capabilities: pointer gesture Tap-to-click: disabled Tap-and-drag: enabled Tap drag lock: disabled Left-handed: disabled Nat.scrolling: disabled Middle emulation: disabled Calibration: n/a Scroll methods: *two-finger edge Click methods: button-areas *clickfinger Disable-w-typing: n/a Accel profiles: flat *adaptive Rotation: n/a

OTOH, I don't see that for the touchpad on my Razer laptop either. But that one does not run wayfire.

[ammen99]

I don't see any attributes in 'libinput list-devices' which obviously maps to "libinput_device_config_tap_get_finger_count". should I expect one?

I'd rather check it by placing a line LOGI("Handling touchpad") in the code .. let me know if don't know any C++, I can prepare a patch for you to test.