EPyT-Flow

EPyT-Flow copied to clipboard

JOSS Review

11

Hi! I will be conducting my JOSS review in this issue. epyt-flow is a really interesting and useful package that offers a large range of functions and very comprehensive documentation!...

meghnathomas

How would you recommend new users learn to use the package? Would you suggest they first go through the in-depth tutorial then recreate all the examples? Since epyt-flow offer so many functions, I think it would be great to include suggestions for how to get started! Or at least add a link to the in-depth tutorial on the landing page since it seems like a very important guide to the package functionalities

2

andreArtelt

Modeling of water distribution networks -> Topology: in the definition of a pump, how do you define "segment?" I would add that pumps add hydraulic head to the system or something to that extent

2

andreArtelt

Scenarios -> Basics: what happens if you don't close the scenario?

2

andreArtelt

Events -> Leakages: how are leaks modeled in epyt-flow? I see leaks are assigned to pipes, unlike in EPANET, where leaks are modeled by assigning emitter coefficients to junctions.

2

andreArtelt

Events -> Actuator events: actuator events are analogous to EPANET time-based controls, correct? What takes precedence if you have both an actuator event and a control acting on an element (e.g., a pump)?

2

andreArtelt

What is the default sensor placement for each network/scenario?

2

andreArtelt

I recommend adding legends to all plots with multiple lines so it is clear what each line represents. And also checking the x and y axis labels and ticks (e.g. in Pump State Events Example top plot, does y axis value = 2.0 means the pump is off and 3.0 mean the pump is on? In the bottom plot, are you plotting tank water volume? I think it is straightforward to interpret the plots if you are a WDS expert but it might be useful to have more clear plots for newer users! :-) )

2

andreArtelt

Event Detection: would it be possible to elaborate a little more on the results and the plot? Is the algorithm able to successfully detect one event but not all three?

2

andreArtelt

Abrupt Leakage Example: not a big deal at all, but would it be possible to standardize the y-axis ticks so it is easier to interpret?

1

andreArtelt