docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon WasmEdge

Fix a typo

Open hiroshi opened this issue 1 year ago • 6 comments

Explanation

Related issue

What type of PR is this

Proposed Changes

hiroshi avatar Jun 27 '24 11:06 hiroshi

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit 4d994af7481c37297dc5f29db646c2b78cac8a36

Key changes:

  • The patch fixes a typo in the install.md file related to the word "the" that was missing before "version."

Potential problems:

  • The patch seems to be a straightforward fix for a typo, so there are no significant potential issues identified.
  • It's always good practice to ensure that changes like these do not introduce any new typos or formatting errors in the document.

Overall, this patch appears to be a simple correction of a typographical error and should not introduce any functional issues.

alabulei1 avatar Jun 27 '24 11:06 alabulei1

Hi @hiroshi Please fix the DCO check, thanks.

hydai avatar Jul 10 '24 19:07 hydai

It is very annoying to do git clone to local for just suggesting a typo in a document...

OK. I'll do it later. :-)

hiroshi avatar Jul 10 '24 22:07 hiroshi

You can use the GitHub website and edit the committer message to append the DCO statement directly.

hydai avatar Jul 11 '24 05:07 hydai

You can use the GitHub website and edit the committer message to append the DCO statement directly.

How do I do this? https://stackoverflow.com/a/10728453

Do you mean that recreate another pull request online and don't forget to add Signed-off-by line?

I don't want to bother you, but I'm just wonder...

hiroshi avatar Jul 11 '24 10:07 hiroshi

If you don't want to clone the repo, you can edit it with the signed-off-by line. Not sure if GitHub allows you to edit the existing commits from the website.

hydai avatar Jul 11 '24 12:07 hydai