docs icon indicating copy to clipboard operation
docs copied to clipboard

fix: installation command for tls plugin

Open dipankardas011 opened this issue 1 year ago • 4 comments

Explanation

as the existing installtion command lead to missing link refering to https://github.com/second-state/http_req#build-and-run

Related issue

What type of PR is this

/kind bug

Proposed Changes

replaced the URL of binary with working one

dipankardas011 avatar Jun 14 '23 14:06 dipankardas011

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 1659873b916f968579af6115870afe5c7770ccf6

Key changes:

  • Updated the openssl-based TLS plugin installation command for WasmEdge.
  • Replaced the old rustls-based plugin download link with an HTTPS request plugin tarball download link.

Potential problems:

  • There are no obvious problems with this patch.
  • It is difficult to detect hidden potential problems without further details about the specific project. The reviewer should ensure that the changes made in the patch are relevant, correct, and consistent with the project's goals.

alabulei1 avatar Jun 14 '23 14:06 alabulei1

@alabulei1 @juntao

dipankardas011 avatar Jun 20 '23 17:06 dipankardas011

Hi @dipankardas011

Thanks for pointing this out. We use rust-tls plugin to replace the wasmedge_httpsreq plugin. So I think the existing docs are right.

alabulei1 avatar Jul 03 '23 04:07 alabulei1

Hi @dipankardas011

Thanks for pointing this out. We use rust-tls plugin to replace the wasmedge_httpsreq plugin. So I think the existing docs are right.

can you review the docs

dipankardas011 avatar Jul 03 '23 06:07 dipankardas011