multiple-cucumber-html-reporter icon indicating copy to clipboard operation
multiple-cucumber-html-reporter copied to clipboard

fix: file name formatting by xregexp

Open Seunghyum opened this issue 2 years ago • 2 comments

Hello :) I still use your wonderful library. Thanks a lot.

This pr is from https://github.com/wswebcreation/multiple-cucumber-html-reporter/pull/148

I'm sorry about my inactivity.

Now I see your answer. thank you I made another solution to cover all language. xregexp package is little bit big (154.4 kb, gzipped 51.4kb). But it will be worth to take :)

If you want to make test case, I will make it in this pr. ;) Thanks to read my pr

Seunghyum avatar Jun 22 '22 07:06 Seunghyum

Oh, I see your solution https://github.com/wswebcreation/multiple-cucumber-html-reporter/pull/148#discussion_r689451200

feature.id = `${ idPrefix }${ feature.id }`.split(" ").join("-").replace(/[^a-zA-Z0-9-_]/g, '-');

Your sugestion is also good. if you want to change your code, i will pr it :)

Seunghyum avatar Jun 22 '22 07:06 Seunghyum

Hi @Seunghyum

Feel free to fix it, then it will be on your name

wswebcreation avatar Jul 29 '22 15:07 wswebcreation

Hi @Seunghyum

Feel free to fix it, then it will be on your name

Okey I will pr soon :) thanks alot

Seunghyum avatar Nov 15 '22 06:11 Seunghyum

@Seunghyum I'll close this PR then, feel free to submit the new one at your earliest convenience. Thanks a lot for your engagement! 😊

BaCaRoZzo avatar Nov 19 '22 13:11 BaCaRoZzo