workbench icon indicating copy to clipboard operation
workbench copied to clipboard

chore(build): Find QuaZip library

Open effigies opened this issue 9 months ago • 4 comments

When building on a Fedora machine, I am unable to find the QuaZip library, when it is installed.

It appears that it needs to be found via QuaZip-Qt*, and populates case-sensitive variables. This patch looks for the specific QuaZip for the version of QT that is being targeted.

I do not know if this generalizes to other operating systems or depends on Linux/Fedora-specific configurations. I will be trying this patch in the conda-forge build as well.

Closes #61. Closes #63.

effigies avatar Mar 06 '25 17:03 effigies

xref #61

effigies avatar Mar 07 '25 12:03 effigies

I've confirmed this works on Fedora and conda-forge, as well as Ubuntu when stacked with #89.

effigies avatar Mar 07 '25 17:03 effigies

This looks like debian has gone in a similar direction with the cmake scripts:

https://packages.debian.org/sid/amd64/libquazip1-qt5-dev/filelist

The debian build logs say it is using the in-source version of quazip at the moment, so perhaps the existing quazip detection code was just aspirational.

@johnvelab @yarikoptic any thoughts?

coalsont avatar Mar 07 '25 23:03 coalsont

sorry -- I was not doing heavy inspection of build logs for the workbench, but I see that we do not have it listed as build-dependency

❯ git grep libqua -- debian || echo nonefound
nonefound

and never installed during package builds

1 neurodebian@smaug ..eb/builds/connectome-workbench/2.0.1-1 % grep libqua *build                                                                                                                                              :(
1 neurodebian@smaug ..eb/builds/connectome-workbench/2.0.1-1 %    

so most likely bundled copy was used indeed. Confirming that building against system wide is preferable.

yarikoptic avatar Mar 10 '25 12:03 yarikoptic