workbench

workbench copied to clipboard

Fails to find Qt and Qwt libraries

5

``` ld: error: unable to find library -lqwt6 ld: error: unable to find library -lQt5Concurrent ld: error: unable to find library -lQt5PrintSupport ld: error: unable to find library -lQt5Svg ld:...

yurivict

This would allow user to control whether tests are built. ```include(Test)``` should also be conditional.

yurivict

``` work/workbench-1.5.0-430-g1e6d5c5c9/src/GuiQt/MapSettingsPaletteColorMappingWidget.cxx|2314 col 31| error: 'QPen' is an incomplete type || curve->setPen(QPen(color)); || ^ /usr/local/include/qt5/QtCore/qmetatype.h|2090 col 1| note: forward declaration of 'QPen' || QT_FOR_EACH_STATIC_GUI_CLASS(QT_FORWARD_DECLARE_STATIC_TYPES_ITER) || ^ /usr/local/include/qt5/QtCore/qmetatype.h|167 col 17| note:...

yurivict

configure allows qwt5 while later you use qwt_series_data.h that is only installed by qwt6

2

I have both of them installed: ``` $ pkg info | grep qwt qwt5-qt5-5.2.3g20210209 Qt Widgets for Technical Applications qwt6-qt5-6.1.6_1 Qt Widgets for Technical Applications ``` Configure picks qwt5: ```...

yurivict

error: use of undeclared identifier 'glGenBuffers'

9

``` | /usr/bin/c++ -DHAVE_FREETYPE -DQT_CORE_LIB -DQT_NO_DEBUG -DWORKBENCH_HAVE_HELP_HTML -DWORKBENCH_USE_QT5_QOPENGL_WIDGET -D_STATICLIBBUILD -I/usr/local/include -I/usr/local/include/qt5/QtNetwork -I/usr/local/include/qt5/QtGui -I/disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/Annotations -I/disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/Brain -I/disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/Charting -I/disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/Cifti -I/disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/CZIlib/CZI -I/disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/FilesBase -I/disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/Files -I/disk-samsung/freebsd-ports/biology/connec work/workbench-1.5.0-430-g1e6d5c5c9/src/Brain/BrainOpenGLShape.cxx|177 col 9| error: use of undeclared identifier 'glGenBuffers' ||...

yurivict

clang fails to compile workbench: error: non-constant-expression cannot be narrowed from type 'int64_t' (aka 'long') to 'int' in initializer list [-Wc++11-narrowing]

2

``` /disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/Algorithms/AlgorithmCiftiSeparate.cxx:657:28: error: non-constant-expression cannot be narrowed from type 'int64_t' (aka 'long') to 'int' in initializer list [-Wc++11-narrowing] int extrema[6] = { myMap[0].m_ijk[0], ^~~~~~~~~~~~~~~~~ /disk-samsung/freebsd-ports/biology/connectome-workbench/work/workbench-1.5.0-430-g1e6d5c5c9/src/Algorithms/AlgorithmCiftiSeparate.cxx:657:28: note: insert an explicit cast...

yurivict

Despite finding QuaZip it fails like this: ``` work/workbench-1.5.0-430-g1e6d5c5c9/src/Operations/OperationZipSpecFile.cxx|28 col 10| fatal error: 'quazip.h' file not found || #include || ^~~~~~~~~~ ```

yurivict

Doesn't print the message about QuaZip correctly

1

This message lacks the library name: ``` QuaZip: Using QuaZip Library ``` because the code looks like this: ``` SET(QuaZip-Qt5_RESULT "Using QuaZip Library ${QuaZip-Qt5_LIBRARIES}") ```

yurivict

cmake files are looking for ```QUAZIP_*``` but the actual name is ```QuaZip-Qt5``` on FreeBSD, Please make this name configurable through cmake variables if you can.

yurivict

workbench-linux64-v1.5.0.zip has too-generous permissions for files and directories

3

Permissions across all files and directories in the zipfile are u=rwx,g=rwx,o=rwx. This is bad if this package is unpacked by an admin intending to install into a privileged location, as...

gdevenyi