HCPpipelines icon indicating copy to clipboard operation
HCPpipelines copied to clipboard

inconsistencies in PreFreeSurferPipeline.sh with AnatomicalAverage.sh

Open aureliocarnero opened this issue 1 year ago • 6 comments

In AnatomicalAverage.sh from PreFreeSurfer. The input Arguments have changed from -n, -o, -s, -m... to: --output, --image-list.... But this is not reflected in PreFreeSurferPipeline.sh which still expect the old format

aureliocarnero avatar Oct 22 '24 08:10 aureliocarnero

I have committed e1eafb1372cb65ba163a4896299c1a408a1069fa to master to try to fix this, give it a try.

coalsont avatar Oct 22 '24 21:10 coalsont

it worked, thanks. But now I found something else along the the PreFreeSurferPipeline.sh. When running robustfov (line 86), before in v4.7.0 it didn't complaint (I don't know if it was executed or not) but now, it tells the brain size is not given correctly as an argument for robustfov. To correct this, I just add the argument -b before the brain size as:

$FSLDIR/bin/robustfov -i ${fn}_reorient -r ${fn}_roi -m ${fn}_roi2orig.mat -b $BrainSizeOpt

aureliocarnero avatar Oct 23 '24 11:10 aureliocarnero

Perhaps the FSL usage changed since this was implemented. We can fix it, but it will break old FSL versions.

Matt.

glasserm avatar Oct 23 '24 14:10 glasserm

That's true. Better not to touch anything. Therefore I'm closing the issue as resolved. If I encounter any other inconsistency in the pipeline while executing it, I will open a new issue. Thank you

aureliocarnero avatar Oct 23 '24 14:10 aureliocarnero

Well, we do need the pipelines to work with newer FSLs, the problem is we don't know in which version this changed, which makes it hard to maintain backwards compatibility.

glasserm avatar Oct 23 '24 15:10 glasserm

True, let me find out in which fsl version happened

El mié, 23 oct 2024, 16:07, glasserm @.***> escribió:

Well, we do need the pipelines to work with newer FSLs, the problem is we don't know in which version this changed, which makes it hard to maintain backwards compatibility.

— Reply to this email directly, view it on GitHub https://github.com/Washington-University/HCPpipelines/issues/313#issuecomment-2432549525, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXSAV5EAYXYD5UOHDLOHUDZ463SJAVCNFSM6AAAAABQL66ULKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZSGU2DSNJSGU . You are receiving this because you modified the open/close state.Message ID: @.***>

aureliocarnero avatar Oct 23 '24 15:10 aureliocarnero