tgm icon indicating copy to clipboard operation
tgm copied to clipboard

Alts enhancements #2

Open Atdit opened this issue 5 years ago • 3 comments

Checks alts whenever a player joins and sends a staff message when at least one muted or banned alt is found. A list of muted/banned alts can be seen when hovering over the message. Muted alts are marked yellow, banned ones are marked red.

Bans color-override mutes just like in https://github.com/Warzone/TGM/pull/651

This also marks online players green (overridden by active mutes and bans) in /alts and solves https://github.com/Warzone/TGM/issues/589 completely except for showing the active punishment by hovering over a name in /alts.

Atdit avatar Jul 04 '20 21:07 Atdit

image image image

Tested.

Atdit avatar Jul 04 '20 21:07 Atdit

While this PR works in essence, I'm afraid of the amount of stress this will put onto the backend. Players often join the server using different accounts which would result in many HTTP requests being sent on each player join. It's also not rare to find players with over 10 alts under the same IP. An alternative solution to this could be implementing an endpoint on the backend that returns all the necessary data in a single request, which wouldn't render this PR useless, just needing a few changes.

jorgeberrex avatar Jul 13 '20 22:07 jorgeberrex

+1 to reducing backend load

jellz avatar Jul 13 '20 22:07 jellz