tgm icon indicating copy to clipboard operation
tgm copied to clipboard

Match end sound effect

Open ghost opened this issue 5 years ago • 8 comments

Describe the bug At the end of each match, there's an awful loud sound which plays. Edit: Also when wool is grabbed.

Client version 1.15.x

To Reproduce Steps to reproduce the bug:

  1. Play either in a match or as a spectator.
  2. Wait for a match to end.

Expected behavior A softer sound effect.

Server Software (Spigot/PaperSpigot): PaperSpigot

ghost avatar Jun 09 '20 02:06 ghost

Is the problem that the sound is too loud or the sound should be changed to something else?

nichxlxs avatar Jun 16 '20 00:06 nichxlxs

The sound is too loud. Therefore, I'm recommending either lower the volume of the sound, or change it overall.

ghost avatar Jun 16 '20 02:06 ghost

The sound is too loud. Therefore, I'm recommending either lower the volume of the sound, or change it overall.

Is this still a recurring issue since June 2020?

benrobson avatar Jan 17 '21 00:01 benrobson

Still a recurring issue

Owehttamy avatar Aug 17 '21 22:08 Owehttamy

In my recent change from just above this, you can change the volume from the Ambient sound category in game. Give this a try and let me know how it goes.

benrobson avatar Aug 17 '21 22:08 benrobson

Make sure you are operating on the latest commit.

benrobson avatar Aug 17 '21 22:08 benrobson

Yes, this is still apparent, as seen here (volume warning, of course) Just to clarify: the changes did seem to fix the KOTH, CTW, and DTM sounds effects, but they didn't fix the match end sound effect.

Owehttamy avatar Aug 17 '21 23:08 Owehttamy

Where the match end sound effect is: https://github.com/benrobson/TGM/blob/fix-end-match-sound/TGM/src/main/java/network/warzone/tgm/modules/MatchResultModule.java#L63 In accordance with the provided footage, it is ignoring AMBIENT.

@jellz @jorgeberrex is this called anywhere else? Thought I replaced these in the entire project.

benrobson avatar Aug 18 '21 06:08 benrobson