warzone2100 icon indicating copy to clipboard operation
warzone2100 copied to clipboard

implement metainfo

Open okias opened this issue 2 years ago • 3 comments

Would make sense to follow domain style naming recommended by FreeDesktop on Linux?

appid proposal: net.wz2100.

okias avatar May 20 '22 21:05 okias

A couple of quick thoughts:

  • Seems like the application id should be net.wz2100.warzone2100 ?
  • Is there any need to rename *.appdata.xml to *.metainfo.xml? (It seems like the "current" recommendation is *.metainfo.xml, but it seems *.appdata.xml is still supported for desktop apps, and we don't want to cause issues with older systems? It's not clear to me what's supported where.)
  • All the removals of ${WZ_OUTPUT_NAME_SUFFIX} should be reverted - this is used to handle branch builds and such so there aren't naming collisions (so presumably for the app-id it would become net.wz2100.warzone2100${WZ_OUTPUT_NAME_SUFFIX}).
    • Presumably the desktop file would still have:
    TryExec=warzone2100@WZ_OUTPUT_NAME_SUFFIX@
    Exec=warzone2100@WZ_OUTPUT_NAME_SUFFIX@
    
    Since that would be the binary name
  • I guess we probably need launchable in the appdata.xml as well?
    <launchable type="desktop-id">net.wz2100.warzone2100${WZ_OUTPUT_NAME_SUFFIX}</launchable>
    

past-due avatar May 23 '22 21:05 past-due

A couple of quick thoughts:

* Seems like the application id should be `net.wz2100.warzone2100` ?

right, make sense

Is there any need to rename *.appdata.xml to *.metainfo.xml? (It seems like the "current" recommendation is *.metainfo.xml, but it seems *.appdata.xml is still supported for desktop apps, and we don't want to cause issues with older systems? It's not clear to me what's supported where.)

generally it should work for long time almost everywhere, I think there was only short frame after releasing appdata which just supported appdata.xml postfix.

All the removals of ${WZ_OUTPUT_NAME_SUFFIX} should be reverted - this is used to handle branch builds and such so there aren't naming collisions (so presumably for the app-id it would become net.wz2100.warzone2100${WZ_OUTPUT_NAME_SUFFIX}).
    Presumably the desktop file would still have:
TryExec=warzone2100@WZ_OUTPUT_NAME_SUFFIX@
Exec=warzone2100@WZ_OUTPUT_NAME_SUFFIX@
Since that would be the binary name

Right, agree.

I guess we probably need launchable in the appdata.xml as well?
<launchable type="desktop-id">net.wz2100.warzone2100${WZ_OUTPUT_NAME_SUFFIX}</launchable>

Depends, if the game executable will be changed, then for sure.

I'll integrate these changes in one-two weeks.

okias avatar May 24 '22 22:05 okias

I just hope configuration directory location and name stays the same. Everyone is very used to it and changing it will be a huge pain for everyone.

maxsupermanhd avatar May 25 '22 00:05 maxsupermanhd