warzone2100 icon indicating copy to clipboard operation
warzone2100 copied to clipboard

`for` to `for-of` loop

Open ximex opened this issue 2 years ago • 4 comments

ready to merge

ximex avatar Mar 30 '22 17:03 ximex

This pull request introduces 4 alerts when merging 85de24df8ef81e692723df33f23f6f1fc75232ca into e6a2865005242d8b3f3e85e57271a79b5af08b80 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Unused loop iteration variable
  • 1 for Useless assignment to local variable

lgtm-com[bot] avatar Mar 30 '22 17:03 lgtm-com[bot]

This pull request introduces 1 alert when merging f5a017e83b02bb52d7ceab42014540298254e286 into e6a2865005242d8b3f3e85e57271a79b5af08b80 - view on LGTM.com

new alerts:

  • 1 for Unused index variable

lgtm-com[bot] avatar Apr 04 '22 16:04 lgtm-com[bot]

@past-due @KJeff01 any change requests?

ximex avatar Apr 04 '22 20:04 ximex

Well, as pastdue had hinted earlier, the use of for ... of won't be acceptable for the moment until more JS engines support the feature. We just don't want to be stuck in a situation where there is one or increasingly less engines that support our scripts. Sorry.

KJeff01 avatar Apr 07 '22 17:04 KJeff01