warzone2100 icon indicating copy to clipboard operation
warzone2100 copied to clipboard

Selecting units using group hotkeys while the game is paused

Open 2404133455 opened this issue 3 years ago • 4 comments

Describe the bug You can press a group hotkey (0-9 on the keyboard) while the game menu is paused. As long as an actual unit group is set for that hotkey, you will be able to select any of those while the game is paused (which also plays the "Group X reporting" voice) and also center on said groups, even if you logically shouldn't (game pauses entirely in singleplayer).

To Reproduce You just have to have an existing unit group during the game. Once you pause the game and the pause menu shows up, you can tap the group selection hotkeys and the above will happen.

Expected behavior Not selecting units while the game is paused, also not playing sound clips while the game is paused.

Here's some footage of the issue from another user. https://youtu.be/H_jTFjjekQY

Your System:

  • OS: Windows 10
  • Game version: 4.2.4

2404133455 avatar Dec 24 '21 17:12 2404133455

This behavior is inconsistent. The user can't click on units to select them while paused but the selection via group hotkeys (0-9) is working. It should either be impossible or possible with mouse and grp hotkeys both.

Same with the minimap btw but dunno if this falls under the same issue. The user can interact with the minimap while paused. I remember an issue some time ago where we disabled the menu HUD interactivity while paused in this issue and PR: https://github.com/Warzone2100/warzone2100/commit/234fe01a0f12c178689e2b3bfcf8f5e84c12bac8

What is the expected behavior here? @past-due @maxsupermanhd @KJeff01

(thanks to LucyTheWolfQueen for testing)

berserkingyadis avatar Dec 28 '21 20:12 berserkingyadis

Players should not be able to issue keybind commands like assignments to group, jump to objects, right-click to jump to map location after unpause, removing status bars, hold right on the minimap to move around on the map while paused, select units and left click the minimap to order them somewhere... and so on.

The only thing players should be able to interact with is changing the size of the minimap as that won't affect actual gameplay.

Lots of places need gamePaused() checks.

KJeff01 avatar Dec 28 '21 21:12 KJeff01

What about hovering over units/buildings to show healthbars? Some games allow this and some don't

berserkingyadis avatar Jan 01 '22 14:01 berserkingyadis

I'm fine with anything as long as the player can't change the game state or issue commands while paused.

KJeff01 avatar Jan 01 '22 16:01 KJeff01