Convert var to let/const

[ximex]

more is coming

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 956e9b8b6eff2034dbd016c882caf457d2c5a3ea into 2ddb23c8b66094797e99074ba8faf74bf42005c6 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 35d097442ad2356196020795be1799da63bdd825 into 2ddb23c8b66094797e99074ba8faf74bf42005c6 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 4bb9d9ae3003650b6f41684fc834b1e93688991f into 2ddb23c8b66094797e99074ba8faf74bf42005c6 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[vaut]

Files from data/mp/multiplay/script please correct too.

[ximex]

Files from data/mp/multiplay/script please correct too.

what should it correct? i already converting the var's in data/mp/multiplay/script

[lgtm-com[bot]]

This pull request introduces 1 alert when merging c7555bd9ebed93a76baeda3cea3b58bd7615f6da into 2ddb23c8b66094797e99074ba8faf74bf42005c6 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[lgtm-com[bot]]

This pull request introduces 1 alert when merging da17647ad7755e16ef9282b80f17fca216ce11d7 into 2ddb23c8b66094797e99074ba8faf74bf42005c6 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[vaut]

Files from data/mp/multiplay/script please correct too.

what should it correct? i already converting the var's in data/mp/multiplay/script

Sorry I didn't see it. Lots of changes ...

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 2d7f778c30241b151529fd20798ab1f511cc966e into 2ddb23c8b66094797e99074ba8faf74bf42005c6 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[ximex]

does someone knows what is the problem for Lint Code Base / Lint Code Base?

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging ebb8f64eea629b0d2a15ef117ca4f79a56aa1cb2 into 2ddb23c8b66094797e99074ba8faf74bf42005c6 - view on LGTM.com

new alerts:

• 1 for Missing variable declaration
• 1 for Unused variable, import, function or class

[thiagorb]

does someone knows what is the problem for Lint Code Base / Lint Code Base?

2021-04-11 21:36:35 [ERROR]   Error code: 1. Command output:
312
------
313

314
/github/workspace/data/mp/multiplay/skirmish/nb_includes/_events.js
315
  19:7  error  Parsing error: Identifier 's' has already been declared
316

317
✖ 1 problem (1 error, 0 warnings) ```

[ximex]

965 var's remaining

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 57d2124fadf68237344d17ca86b2ae06f2741d44 into d9fd9a7888d05696641c28e54f8b9c0bec0a3796 - view on LGTM.com

new alerts:

• 1 for Assignment to constant

[ximex]

i added some // TODO: never used comments in bonecrusher files where the variable is never used. should i remove that 9 variables? except of that this PR is ready

[lgtm-com[bot]]

This pull request introduces 3 alerts when merging ff18235bb6609b25ad2e7216e12f5a4e949300b4 into 76321ad11b33f038d64994c8a6a06e4830f19e37 - view on LGTM.com

new alerts:

• 2 for Assignment to constant
• 1 for Syntax error

[EuPhobos]

i added some // TODO: never used comments in bonecrusher files where the variable is never used. should i remove that 9 variables? except of that this PR is ready

You can jsut delete all stuff wich "Never used". This seems to old code wich i forgote to delete, or new one but never implemented.